Pavel Bodiachevskii
Pavel Bodiachevskii
> > If failed tests didn't block release or merges, I'm ok with it > > Lets see whether it's the test that are wrong or the actual schemas first...
> > > > If failed tests didn't block release or merges, I'm ok with it > > > > > > > > > Lets see whether it's the...
> So far I can see the following skipped tests (that need to be addressed): > > * AMQP 0.2.0 channel binding, 3 skipped test > * AMQP 0.3.0 channel...
> > Current implementation tells that null is not allowed, which is not correct > > @Pakisan do you mean current implementation of the JSON Schema files or? > >...
Here is `ServerVariable` class ```java @Data @Builder @NoArgsConstructor @AllArgsConstructor @EqualsAndHashCode(callSuper = true) public class ServerVariable extends ExtendableObject { /** * An enumeration of string values to be used if the...
@jonaslagoni agree. Will create proposal to add null and create discussion to discuss current state of Schemas What I need to improve, to merge tests as is and fix them...
@smoya fyi
@jonaslagoni @smoya Basic test structure is next: - schema: - empty - example - without required fields - only required fields - extended - wrongly extended Let's merge it. I'll...
> LGTM :+1: Can't find review, which is blocking merge, when approves appear
> Hi everybody, > > One thing I've noticed are fixture files containing empty spaces. Example: `./without required properties.json` > > Wouldn't kebab-case or snake-case be more appropriate here? >...