Unitful.jl icon indicating copy to clipboard operation
Unitful.jl copied to clipboard

Move const `q` under `Constants`

Open KronosTheLate opened this issue 3 years ago • 8 comments
trafficstars

This PR moves the definition of the constant q under "Constants". See #556.

I also changed the comment on the line defining q from "e means 2.718..." to "avoid naming conflict with e", as I feel the original phrasing could be confused with the e in the line that means "times 10 to the power of..."

KronosTheLate avatar Sep 12 '22 17:09 KronosTheLate

You only moved the definition of q. The definition of eV needs to be moved as well, since it uses q.

sostock avatar Sep 14 '22 06:09 sostock

Nice catch @sostock. However, eV is not a constant, but a unit. So I will move it to under the "constants" section, right?

KronosTheLate avatar Sep 14 '22 06:09 KronosTheLate

Once you are working on the constants: are you aware of #545 ?

j-fu avatar Sep 14 '22 07:09 j-fu

not at all

KronosTheLate avatar Sep 14 '22 08:09 KronosTheLate

However, eV is not a constant, but a unit. So I will move it to under the "constants" section, right?

IMO, you can also move it into the constants section (right below q), since there are other units that are defined in that section as well (c, u).

sostock avatar Sep 14 '22 14:09 sostock

That is not an argument to move eV into the constants section, but rather c and u out of it IMO.

KronosTheLate avatar Sep 14 '22 17:09 KronosTheLate

That’s fine too, although I like that the units are defined immediately after the constants on which they are based.

sostock avatar Oct 09 '22 15:10 sostock

There is sone appeal, but I personally look up the variables for constants all the time, and love having them all in one place. So that has more weight to me, as I frequently make use of it.

KronosTheLate avatar Oct 10 '22 04:10 KronosTheLate