Paint_Ninja
Paint_Ninja
Superseded by #10074
Marking as a draft as this PR is incomplete. @RealMangorage once you've finished working on this, please mark it as ready for review to continue.
Apologies for the confusion - OldTags is a temporary backup file I made to make it easier to keep track of what's left to do with the PR. It will...
Okay, had a look through and it seems reasonably well thought out... *a lot* of existing Forge tags are reused, bar some being renamed to plurals (e.g. `STONE` -> `STONES`)...
> ## Tag Application > This is more difficult, and I don't entirely know if it is in the scope of this PR, although it really should be. The common...
@MinecraftForge/triage This PR is finally ready for review - I've even gone the extra mile with Lex's help to hopefully ensure no breaking changes and pre-emptively accounting for a new...
Main things to check are: - Typos in the field and tag names that aren't also on Fabric or Neo - If we've accidentally adopted any loader-specific `c:` tags -...
Thank you! > Even though https://github.com/FabricMC/fabric/pull/4114 has yet to be merged, it's been approved so I don't think it's a problem. Correct. Forge has it as `forge:foods/pie` until Fabric merges....
I don't think you're handling cache invalidation properly for the primitive values. Sure, the inherited set() method changes the value field, but it doesn't set it to null, which is...
Closing as stale - the PR is incomplete/broken for the better part of a year without progressing. If you'd like to continue this, please open a new PR.