terraform-provider-pagerduty icon indicating copy to clipboard operation
terraform-provider-pagerduty copied to clipboard

resource/pagerduty_extension: Allow config to be computed

Open heimweh opened this issue 6 years ago • 8 comments

This PR brings changes to the config field and allows it to be computed.

Unfortunately testing this proved to be quite difficult due to how the API behaves with a missing config on resource creation, but this should resolve the issue described in #94.

Fixes #94.

heimweh avatar Aug 17 '18 10:08 heimweh

Indeed, that should do it. Thanks!

pdecat avatar Aug 17 '18 13:08 pdecat

Quite hard to automatically test indeed.

While looking into it, I've noticed the import function was lacking support for the config field. I've created a PR to add a test case and fixed that in PR #96.

pdecat avatar Aug 20 '18 10:08 pdecat

Please merge :)

shaun-mills avatar May 24 '19 20:05 shaun-mills

Hi @heimweh, is there anything blocking this PR then #96 from being merged?

pdecat avatar Jul 10 '19 07:07 pdecat

Obligatory bump.

nathanielks avatar May 20 '20 16:05 nathanielks

what about this PR? why it isnt merged yet ?! i want this !!!

cmardonespino avatar Jul 15 '20 05:07 cmardonespino

I'd also like to know what the status is on this PR

sparky005 avatar Nov 16 '20 16:11 sparky005

Hi @stmcallister 👋 Just wanted to flag you on this one in case there is a possibility to get it merged soon. It would address a long-standing problem and it'd be great to have it fixed. If there's anything the community can do to help get this PR merged, please let us know. I'd be glad to try to pitch in.

acrewdson avatar Apr 01 '21 18:04 acrewdson