PaddleSpeech icon indicating copy to clipboard operation
PaddleSpeech copied to clipboard

Fixed implementation of a special method

Open nydelzaf opened this issue 2 years ago • 3 comments

PR types

Bug Fixes

PR changes

Others

Describe

This PR does the following-

  1. Adds missing imports for paddlespeech/s2t/io/reader.py and paddlespeech/audio/transform/perturb.py file.
  2. Fixes an implementation of a special method (__len__) for SoundHDF5File class.

Our bug fixing tool generated the following message-

In file: reader.py, class: SoundHDF5File, there is a special method len that contains an unexpected number of parameters. Each call to this method will result in a TypeError. iCR suggested that special methods should have an expected number of parameters. More infomation can be found in the Python documentation on the various special method.

CLA Requirements:

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed - to improve global software supply chain security.

The bug is found by running the iCR tool by OpenRefactory, Inc. and then manually triaging the results.

nydelzaf avatar Oct 03 '23 13:10 nydelzaf

Thanks for your contribution!

paddle-bot[bot] avatar Oct 03 '23 13:10 paddle-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 03 '23 13:10 CLAassistant

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 07:12 stale[bot]