Paddle icon indicating copy to clipboard operation
Paddle copied to clipboard

[API] `paddle.slogdet` 返回值规范化

Open aquagull opened this issue 6 months ago • 8 comments
trafficstars

PR Category

User Experience

PR Types

Bug fixes

Description

原先paddle.slogdet返回的是一个Tensor, Shape 为 [2, *]。现跟torch、numpy对齐,返回值为tuple(Tensor, Tensor)即tuple(sign, logdet)。

参考标准:https://data-apis.org/array-api/latest/extensions/generated/array_api.linalg.slogdet.html#slogdet

aquagull avatar Apr 26 '25 08:04 aquagull

你的PR提交成功,感谢你对开源项目的贡献! 请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。 Your PR has been submitted. Thanks for your contribution! Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot[bot] avatar Apr 26 '25 08:04 paddle-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 26 '25 08:04 CLAassistant

符号推导部分可以参考这个https://github.com/PaddlePaddle/Paddle/issues/66444 ,写一下测试过覆盖率测试 CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

fangfangssj avatar Apr 30 '25 13:04 fangfangssj

符号推导部分可以参考这个#66444 ,写一下测试过覆盖率测试 CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

单测是有开启符号推导的。 image

    def test_check_output(self):
        self.check_output(check_pir=True) < --- check_symbol_infer 默认为true

CE-Framework的测试是针对之前的api,所以会出现错误。 image

aquagull avatar May 01 '25 11:05 aquagull

符号推导部分可以参考这个#66444 ,写一下测试过覆盖率测试 CE-Franework可以使用PaddleTest/framework/api/run_paddle_ci.sh和PaddleTest/inference/python_api_test/parallel_run.sh在本地测试debug

单测是有开启符号推导的。 image

    def test_check_output(self):
        self.check_output(check_pir=True) < --- check_symbol_infer 默认为true

CE-Framework的测试是针对之前的api,所以会出现错误。 image

好的好的

fangfangssj avatar May 01 '25 11:05 fangfangssj

Sorry to inform you that 3bbe340's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle-ci-bot[bot] avatar May 25 '25 02:05 paddle-ci-bot[bot]

Sorry to inform you that 6900484's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle-ci-bot[bot] avatar Jun 06 '25 03:06 paddle-ci-bot[bot]

/re-run all-failed

aquagull avatar Jun 23 '25 06:06 aquagull

/re-run distribute build

HydrogenSulfate avatar Jun 30 '25 02:06 HydrogenSulfate

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e1842d4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/tensor/linalg.py 10.00% 9 Missing :warning:
.../interface/infer_symbolic_shape/unary_infer_sym.cc 0.00% 6 Missing :warning:
...hi/kernels/impl/slogdeterminant_grad_kernel_impl.h 84.37% 5 Missing :warning:

:x: Your patch status has failed because the patch coverage (72.22%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #72505   +/-   ##
==========================================
  Coverage           ?   72.22%           
==========================================
  Files              ?        6           
  Lines              ?       72           
  Branches           ?        0           
==========================================
  Hits               ?       52           
  Misses             ?       20           
  Partials           ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jul 06 '25 19:07 codecov-commenter

/re-run all-failed

aquagull avatar Jul 09 '25 13:07 aquagull

@aquagull 麻烦合入一下最新的上游代码吧,好像CINN这个有点问题

HydrogenSulfate avatar Jul 15 '25 03:07 HydrogenSulfate

Sorry to inform you that c83b8d4's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle-ci-bot[bot] avatar Jul 25 '25 02:07 paddle-ci-bot[bot]