Paddle icon indicating copy to clipboard operation
Paddle copied to clipboard

【Hackathon 6th No.10】Add isin API to Paddle -part

Open NKNaN opened this issue 1 year ago • 1 comments
trafficstars

PR Category

User Experience

PR Types

New features

Description

rfcs: https://github.com/PaddlePaddle/community/pull/884

NKNaN avatar Apr 30 '24 04:04 NKNaN

你的PR提交成功,感谢你对开源项目的贡献! 请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。 Your PR has been submitted. Thanks for your contribution! Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot[bot] avatar Apr 30 '24 04:04 paddle-bot[bot]

@jeff41404 paddle.searchsorted currently does not support fp16 and bf16. I think the reason may be that the two input tensors' data type of paddle.searchsorted could be different, and since fp16 and bf16 has lower precision than float32 and float64, the comparision between them may be less meaningful.

NKNaN avatar May 14 '24 03:05 NKNaN

@jeff41404 paddle.searchsorted currently does not support fp16 and bf16. I think the reason may be that the two input tensors' data type of paddle.searchsorted could be different, and since fp16 and bf16 has lower precision than float32 and float64, the comparision between them may be less meaningful.

the logic of searchsorted also supports comparing two inputs with different data types. Registering the fp16 and bf16 data types in the Operator should support these two data types. searchsorted operator was developed many years ago, when fp16 and bf16 were not yet widely used, and it was not intentionally unsupported due to accuracy or lower precision.

jeff41404 avatar May 15 '24 09:05 jeff41404

the logic of searchsorted also supports comparing two inputs with different data types. Registering the fp16 and bf16 data types in the Operator should support these two data types. searchsorted operator was developed many years ago, when fp16 and bf16 were not yet widely used, and it was not intentionally unsupported due to accuracy or lower precision.

Got it. Let me update the searchsorted to support fp16 and bf16 first.

NKNaN avatar May 15 '24 09:05 NKNaN

Sorry to inform you that ce38eb2's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

paddle-ci-bot[bot] avatar May 21 '24 03:05 paddle-ci-bot[bot]