Paddle
Paddle copied to clipboard
Adapting device-specific Extra Attributes for the PHI kernel
PR types
New features
PR changes
Others
Describe
Adapting device-specific Extra Attributes for the PHI kernel
你的PR提交成功,感谢你对开源项目的贡献! 请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。 Your PR has been submitted. Thanks for your contribution! Please wait for the result of CI firstly. See Paddle CI Manual for details.
Could you help to review this PR and evaluate these changes on your internal system? After this PR is merged, we can start the migration of remaining kernels @jczaja @Silv3S
Could you help to review this PR and evaluate these changes on your internal system? After this PR is merged, we can start the migration of remaining kernels @jczaja @Silv3S
Yes, we will review changes and check performance/accuracy in our internal validation
We've run first performance and functional tests and this PR passed everything with expected results. We will run one more test on other platform, to make sure that everything is ok. Tests will be finished by the end of this week.
Meanwhile we tried to migrate softmax
kernel with changes from this branch and everything is working as expected 👍 https://github.com/PaddlePaddle/Paddle/pull/47339
@Silv3S Hello, are the tests finished?
LGTM There are small differences in accuracy (some positive, some negative). We will run more test after this PR is merged, as they are more stable.