CINN icon indicating copy to clipboard operation
CINN copied to clipboard

fix_issue583_Remove unnecessary null pointer checks

Open enkilee opened this issue 2 years ago • 5 comments

fix_issue583_remove_nullpoint: https://github.com/PaddlePaddle/CINN/issues/583 del: An extra null pointer check is not needed in functions like the following.

Buffer::DeallocHost Shape::Resize

enkilee avatar Jan 06 '23 01:01 enkilee

Would an other commit message be more helpful?

@elfring What do you mean about an other commit message?

luotao1 avatar Jan 06 '23 06:01 luotao1

:thought_balloon: I suggest to improve commit messages according to known information sources.

elfring avatar Jan 06 '23 07:01 elfring

Please provide an improved merge/pull request with consistent changes.

@enkilee You can update the PR title and improve the PR description.

luotao1 avatar Jan 06 '23 10:01 luotao1

:thinking: Would you like to take further update candidates into account?

elfring avatar Jan 06 '23 11:01 elfring

🤔 Would you like to take further update candidates into account?

Sure, we will try to fix more places like these in the near future. @elfring Thank you for the code improvement suggestion.

zhhsplendid avatar Jan 09 '23 03:01 zhhsplendid