Padarn Wilson

Results 93 comments of Padarn Wilson

> Kernel fusion: Optimize aggregations, e.g., by computing multiple aggregations in parallel (at best discussed in a separate issue) Do we have an open issue on this? I'd be interested...

Thanks. FYI I'll also do this for the link loader and add examples in separate PRs, so we can iterate on the complexity later too if it seems okay but...

Hey @mananshah99 do you also want to take a look at this one? May need to merge it with https://github.com/pyg-team/pytorch_geometric/pull/5312

Thanks for the comments @mananshah99. Sorry I've been busy with my day job, will review and address over the weekend.

On second look I think I'll wait for you to finish your current refactoring PRs, the code has changed a lot and I'll have to fit into the new interface....

Great! I can refactor later this week. I'll probably start a new PR as I think most of the code need to move, will definitely ask you for a review.

hey @mingfeima this issue is great, a lot of detail. > `NeighborLoader` parallelization: the current impl is sequential (probably to avoid oversubscription with multiple workers on the data loader). Unlike...

That makes complete sense. Let me know if you'd like any help (I'd likely not be quick though 😅)

Interesting idea for a feature: Seems like something a lot of people could possibly use. Just wanted to query a bit on > One solution is to save each example...

Could also consider trying to do something with formats like https://capnproto.org/ and mem maps. https://groups.google.com/g/capnproto/c/Q_9klBP6rrg