Koki Fushimi
Koki Fushimi
I don't know why only 2 tests are failed. 
It's strange to use `hello:\r\0\r` to test for Windows. It should be `hello:\r\n\r`.
I asked this in YAML community, and the file `hello:\r\0\r` is malformed. We should fail this even for `load_all_file` and `load_file` and `load` but only `load_all` fails. Hmm, why?
#211 fixes this.
Which is better? ```julia abstract type YAMLVersion end struct YAMLV1_1
Year, the latter should be ```julia struct YAMLVersion{T} end const YAMLV1_1 = YAMLVersion{:Version1_1}() const YAMLV1_2 = YAMLVersion{:Version1_2}() # definition forwardchars!(::YAMLVersion{:Version1_1}, stream::TokenStream, n::Integer=1) #... # call forwardchars!(YAMLV1_1, stream) ``` We can...
I have asked this in Discourse: [Which is better for traits? Subtyping vs parametric typing](https://discourse.julialang.org/t/which-is-better-for-traits-subtyping-vs-parametric-typing/115899)
I asked this also in Julia Slack's internal channel. Simon Byrne said > I think that’s my fault. Not sure I would make it parametric if I were to do...
Let's use abstract type & subtyping pattern.
[JuliaFormatter](https://github.com/domluna/JuliaFormatter.jl) will be fine. I made a configuration for YAML.jl: ```toml # .JuliaFormatter.toml # Formatting options for the default style supported in JuliaFormatter v1.0.56. # https://domluna.github.io/JuliaFormatter.jl/stable/ # style = "default"...