px4_ros_com icon indicating copy to clipboard operation
px4_ros_com copied to clipboard

Confusing description & links to documentation

Open not7cd opened this issue 1 year ago • 2 comments

Hey, I got confused by the role of this package. The sidebar description says:

ROS2/ROS interface with PX4 through a Fast-RTPS bridge

While README says:

This package materializes the ROS2 side of the PX4 DDS bridge, establishing a bridge between the PX4 autopilot stack through an XRCE-DDS bridge. ...

Later it links to https://docs.px4.io/main/en/middleware/micrortps.html, which redirects to https://docs.px4.io/main/en/middleware/uxrce_dds.html. So I don't know if this package is still relevant. px4_ros_com appears 3 times on the later page without much context.

Also, README still links to the defunct Slack.

not7cd avatar Jun 14 '23 10:06 not7cd

Hi @not7cd , yes, this repo requires some work as PX4 moved from Fast-RTPS to XRCE-DDS. The packages itself provides a library for PX4-ROS frame conversions and some example of ROS 2 - PX4 operations.

beniaminopozzan avatar Jun 14 '23 19:06 beniaminopozzan

I think it would be best to reflect this in the project's description then. Maybe create a highlighted text pointing out the migration.

not7cd avatar Jun 14 '23 19:06 not7cd