PX4-user_guide icon indicating copy to clipboard operation
PX4-user_guide copied to clipboard

Orbit Yaw Parameter

Open Claudio-Chies opened this issue 1 year ago • 4 comments

Relevant PR: Updated the documentation to reflect the changes proposed in

  • [ ] https://github.com/PX4/PX4-Autopilot/pull/23358

Cleared up some errors whereby Parameters for the Orbit existed but were not mentioned.

Claudio-Chies avatar Jul 03 '24 13:07 Claudio-Chies

OK, this looks great. I removed the parameter change and ran prettier.

One more thing, is this going into PX4 v1.15 or main? Depending on which, we need to add a release note to either https://docs.px4.io/main/en/releases/1.15.html or https://docs.px4.io/main/en/releases/main.html - can you do that?

hamishwillee avatar Jul 04 '24 01:07 hamishwillee

@Claudio-Chies Before this goes it it will need that release note in https://docs.px4.io/main/en/releases/main.html - can you do that please? (I am assuming the answer is that this is not going into PX4 v1.15)

hamishwillee avatar Jul 10 '24 04:07 hamishwillee

@hamishwillee updated the release notes as requested. but we will have to wait until https://github.com/mavlink/mavlink/pull/2132 gets sorted before merging

Claudio-Chies avatar Jul 10 '24 06:07 Claudio-Chies

@Claudio-Chies Link needs to be fixed, but this can be merged right?

hamishwillee avatar Aug 08 '24 23:08 hamishwillee

Yea, and i need to wait for the qgroundcontrol PR, i'll try to do it today

Claudio-Chies avatar Aug 09 '24 05:08 Claudio-Chies

@Claudio-Chies Link needs to be fixed, but this can be merged right?

@hamishwillee actually, i dont know where LinkedFileMissingAnchor comes from, i'm not changing or referencing anything in airframe_reference.md

Claudio-Chies avatar Aug 09 '24 08:08 Claudio-Chies

@Claudio-Chies I rebased against main and the flaw disappeared. So I suspect this was never in your code.

Ping me when you want this merged (I am taking your comment above to mean you are waiting on something in QGC)

hamishwillee avatar Aug 10 '24 05:08 hamishwillee

@hamishwillee now its ready to be merged, QGC got merged

Claudio-Chies avatar Aug 15 '24 06:08 Claudio-Chies

No flaws found

github-actions[bot] avatar Aug 15 '24 06:08 github-actions[bot]

Done. Yay. Congratulations :-)

hamishwillee avatar Aug 15 '24 07:08 hamishwillee