PX4-Flow icon indicating copy to clipboard operation
PX4-Flow copied to clipboard

Published 20 hours ago • verified publisher icon PX4

Sonar Performance Degradation

Open jgoppert opened this issue 10 years ago • 2 comments

Master 91e6 master-91e6

Ae201 (before mode filter etc.) revert-ae201

I believe that the complexities introduced by the on-board filtering are unwarranted for the performance gain. It also is causing a loss of information as the 0 return code is mapping both out of range close and out of range far to the same value. As a possible solution, I created a branch that adds an error status to the i2c frame (nominal, unint, low, high): https://github.com/jgoppert/Flow/commit/98635635978f5341c1ec4d0f2d2d5ee51aaeb3c4 This would also require the same change on the FMU side and some modification to position_estimator_inav.

jgoppert avatar Jan 20 '15 08:01 jgoppert

The suggestion makes sense.

LorenzMeier avatar Jan 21 '15 06:01 LorenzMeier

Hi James, how is this PR looking? Any chance to take another stab getting this into master? The issue I'm having is that the flow driver will probably silently fail - we need to introduce a version tag and escalate the issue to the GCS. Or we need to map near and far to e.g. -1 and -2 and keep the frame format intact.

LorenzMeier avatar Apr 24 '15 12:04 LorenzMeier