Vincent Petry

Results 505 comments of Vincent Petry

we should at least update pdf.js to the latest version, in case some of these are fixed also, if they tested NC

looks like master is already on the latest version https://www.npmjs.com/package/pdfjs-dist (2.14.305) from 2 months ago

when download is disabled, we should remove the PDF viewer option because there is currently no way to display a PDF without actually downloading it cc @CarlSchwan

@Raudius yes, there was a discussion about that but not sure about effort required to make it work

in the case of the viewer it would be a good idea to remove the actions from the UI when the download permission is not given yes

I had this too, the problem was that some of the size accounting was not up to date. Background: to optimize size propagation, Nextcloud uses an algorithm that adds or...

- [ ] BUG: dialog doesn't close after creating a user, it just empties itself (same with an without the admin password prompt)

@CarlSchwan can you test and tick the checkbox to confirm ?

we already have background-job:execute but I heard it doesn't work for all types and requires a job id, not a class name

I've fixed the unit tests locally, I'll push after I see the acceptance test results... some rely on texts/labels sometimes