yamaha-nodejs icon indicating copy to clipboard operation
yamaha-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon PSeitz

Can we make PRs that use http requests?

Open alanbacon opened this issue 4 years ago • 2 comments

There is a certain feature I wanted to make a PR for, but the feature only works over HTTP, and not with the XML interface.

Can you see a problem with this? Are you trying to support devices that don't support the JSON API?

alanbacon avatar Mar 27 '20 11:03 alanbacon

Actually managed to work this out using XML, but I'm still interested in the answer to this question

alanbacon avatar Mar 27 '20 12:03 alanbacon

JSON and XML are both HTTP, just different formats. Older receivers support only XML, newer support both, so XML is preferable for compatiblity. If there is something only available for JSON, I would not mind integrating it, but I can't test it, because my receiver is too old :)

PSeitz avatar Mar 27 '20 20:03 PSeitz