Tax-Calculator icon indicating copy to clipboard operation
Tax-Calculator copied to clipboard

Rename SS_thd50 and SS_thd85 to SS_thd1 and SS_thd2

Open MaxGhenis opened this issue 3 years ago • 2 comments

I think SS_thd50 and SS_thd85 are the only policy parameters with their default values in their name. This also diverges from SS_percentage1 and SS_percentage2 which are set to 0.5 and 0.85, respectively. Renaming the thresholds to SS_thd1 and SS_thd2 would be more consistent.

The variable descriptions also specify 50% and 85% in them, unlike other thresholds.

MaxGhenis avatar May 31 '21 01:05 MaxGhenis

@jdebacker Is this issue solved??

TishaJhabak1014 avatar Oct 02 '21 05:10 TishaJhabak1014

@TishaJhabak1014 This issue is still open. It will make a change that is backwards incompatible. I've created a new v4_development branch to merge the changes related to this issue into whenever someone decides to tackle it.

jdebacker avatar Oct 02 '21 18:10 jdebacker