PSAppDeployToolkit icon indicating copy to clipboard operation
PSAppDeployToolkit copied to clipboard

Show-InstallationWelcome doesn't have french support for countdown timer

Open JeeBee14 opened this issue 2 years ago • 7 comments

The installation welcome window still shows the countdown in english even though the rest of the UI is in french. Screenshot 2023-02-07 081536

JeeBee14 avatar Feb 07 '23 13:02 JeeBee14

I think this is a known issue. The GUI would need an additional variable that would be read from the XML. This new string in the XML would also need to be translated to all currently supported languages. French is not singled out, BTW.

This is one of many GUIs that are using the old way of doing GUIs: WinForms. The new way is WPF XAML.

I think the reboot screen has a similar issue.

My impression is that this issue will only be looked at in V4. Any work in the GUIs should be converting them to WPF XAML and then add the additional variable to resolve your issue.

That-Annoying-Guy avatar Feb 07 '23 18:02 That-Annoying-Guy

The XML already has the appropriate strings. It's just not been translated. image

Open AppDeployToolkitConfig.xml in a text editor. Search for UI_Messages_FR and edit the string in <WelcomePrompt_CountdownMessage></WelcomePrompt_CountdownMessage>

justsomemate avatar Mar 10 '23 00:03 justsomemate

IOW: This issue is now fixed in 3.9.2

That-Annoying-Guy avatar Mar 10 '23 14:03 That-Annoying-Guy

IOW: This issue is now fixed in 3.9.2

No, I changed the text in my local copy to have a translated French string. The same (English) string is present in 3.8.4, too

justsomemate avatar Mar 10 '23 15:03 justsomemate

Confirmed!

    <WelcomePrompt_CountdownMessage>The {0} will automatically continue in:</WelcomePrompt_CountdownMessage>

the string:

The {0} will automatically continue in:

has not translated for the following languages: French Danish Italian Japanese Norwegian (Bokmål) Polish Portuguese (Portugal) Portuguese (Brazil) Spanish Swedish Arabic Hebrew Korean Russian Chinese (Simplified) Chinese (Traditional)

That-Annoying-Guy avatar Mar 10 '23 15:03 That-Annoying-Guy

If anyone can translate that string to the relevant languages where it's missing, please share them with us and we can add them into the toolkit. We either rely on people to provide us with translations or have a paid service do it for us since we can't be sure if a free online translation service will get it right.

mmashwani avatar Mar 12 '23 14:03 mmashwani

I could translate it for you guys. The only thing is that in the XML we would need a conditional value according to the Deployment Type as the wording would change depending on whether it is "Installation" or "Désinstallation". Let me know if this is doable in XML and I’ll gladly translate it for you guys.

Le dim. 12 mars 2023 à 10:35, Muhammad Mashwani @.***> a écrit :

If anyone can translate that string to the relevant languages where it's missing, please share them with us and we can add them into the toolkit. We either rely on people to provide us with translations or have a paid service do it for us since we can't be sure if a free online translation service will get it right.

— Reply to this email directly, view it on GitHub https://github.com/PSAppDeployToolkit/PSAppDeployToolkit/issues/752#issuecomment-1465215492, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQHT3SMAFBZEKBC5H6D23W3XUMTANCNFSM6AAAAAAUT6QHX4 . You are receiving this because you authored the thread.Message ID: @.***>

JeeBee14 avatar Mar 12 '23 15:03 JeeBee14