PRR24

Results 32 comments of PRR24

Closing the issue as using UTC may be initially unexpected, but still a valid implementation and for local time zone use workaround have been provided.

Technically it should be proibably implemented as: ```js Object.defineProperty(navigator.connection, "saveData", { get: function() { return true; } }); ```

There are currently no e2e binary stream tests. Here is the example of failing test, please add to the most suitable test file. ```js it('should not destroy binary file', function...

According to the doc, buffer is true by default. It changing it affects the outcome, there is possibly another smaller defect.

I think I found the cause of the problem: line 34 in write-stream.js is currently reading _... encoding.enc !== ..._. It should be _... codec.enc !== ..._ instead. After making...

@KarelWintersky You may try, if an in-place patch of ```node_modules/vinyl-fs/lib/dest/write-contents/write-stream.js:34``` as per above solves the problem for you. If yes, this is a global fix.

Not sure I fully understand expectations about the ipAddress field...

There is no such thing as "IP of the user" in IPV4 world. There is only a "IP of the user from specific server perspective". Eg, my/your server may have...

There are number of indirect dependencies to picocolor from @angular-devkit/build-angular Not sure which one of those specificly causes the issue to appear.

Forgot to specify that the my issue appears with Angular 16.latest SSR build.