prql icon indicating copy to clipboard operation
prql copied to clipboard

build: invalidate certain cargo-install caches, fixing Win build pt 2

Open kgutwin opened this issue 6 months ago • 7 comments

I took one last look at the Windows build failure messages, and this is another stab at maybe fixing them. Hopefully invalidating the baptiste0928/cargo-install@v3 caches for cargo-insta and wasm-pack will let Windows rebuild and properly use those tools...

kgutwin avatar Jul 02 '25 01:07 kgutwin

so close, looks like just one more cache (cargo-nextest) needs to be invalidated...

kgutwin avatar Jul 02 '25 01:07 kgutwin

I just wiped them all, will try again!

max-sixty avatar Jul 02 '25 02:07 max-sixty

It's so close, now!

https://github.com/PRQL/prql/actions/runs/16014368312/job/45178110951?pr=5346#step:15:880

Looks like the doctests somehow also need the linker patch.

kgutwin avatar Jul 02 '25 02:07 kgutwin

I'm not sure why setting RUSTFLAGS didn't have any effect on the doctest compilation failure. Cross fingers that the upstream regression gets fixed, then we don't need this. https://github.com/rust-lang/rust/issues/141626#issuecomment-3027216890

kgutwin avatar Jul 02 '25 15:07 kgutwin

@kgutwin windows now seems to pass on main!

max-sixty avatar Jul 16 '25 01:07 max-sixty

wait, are you sure? I still see this failure from the most recent "tests" run on main: https://github.com/PRQL/prql/actions/runs/16300971426/job/46035208345

kgutwin avatar Jul 16 '25 01:07 kgutwin

bah you're right! I'm not sure why it shows green here image

max-sixty avatar Jul 16 '25 03:07 max-sixty