prql icon indicating copy to clipboard operation
prql copied to clipboard

fix: verify msrv with rust-version fields (with cargo-msrv 0.16)

Open eitsupi opened this issue 1 year ago • 4 comments

Given that cargo's MSRV-aware resolver will soon be enabled by default, MSRV validation will become more and more important.

eitsupi avatar Oct 09 '24 11:10 eitsupi

It seems that ubuntu-latest is bumped from Ubuntu 22.04 to 24.04 today. That seems causing test failure.

Edit: Fixed by #4942

eitsupi avatar Oct 09 '24 11:10 eitsupi

~~It appears that the MSRV of the entire workspace must be higher than the MSRV of the individual crates. So here lutra is 1.77.2 and the workspace should not have a lower rust-version than this. (For me, there is a question whether it is reasonable to make lutra a member of the workspace.)~~

Sorry, but this was a misunderstanding, see foresterre/cargo-msrv#1023.

eitsupi avatar Oct 09 '24 12:10 eitsupi

@max-sixty Do you remember why the MSRV checks were only available for nightly builds? To me this seems rather odd.

eitsupi avatar Oct 09 '24 13:10 eitsupi

@max-sixty Do you remember why the MSRV checks were only available for nightly builds? To me this seems rather odd.

"nightly" is a bit of a misnomer — it's run on any big change, such as a dependency change. It's not run on every tiny change though, the change of something breaking is quite low, and would get picked up in the scheduled run.

max-sixty avatar Oct 09 '24 17:10 max-sixty