PyTorch-StudioGAN icon indicating copy to clipboard operation
PyTorch-StudioGAN copied to clipboard

Fix CAS computation

Open sup3rgiu opened this issue 2 years ago • 1 comments

  • missing optimizer.zero_grad()
  • validation accuracy was computed on the training set instead of the validation set
  • fix log

Also, I believe would be better to generate a fake dataset only once and use it to train the classifier for N epochs. So, the correct pipeline would be:

  1. Generate a fake dataset of the same length (and same number of images per class, preferably) of the original training dataset (e.g: CIFAR10 -> 5000 images per class)
  2. Shuffle the dataset
  3. Train the classifier for N epochs and at the end of each epoch compute the accuracy on the original validation dataset

sup3rgiu avatar Dec 26 '22 13:12 sup3rgiu

Thanks. I will review the PR and reflect it if there is no problem.

Again thank you for your contribution!

mingukkang avatar Apr 18 '23 03:04 mingukkang