PMStanley
Fix output file compressed size and icon name
Fixed output file size and name. Also updated the name for the input ones, although this tool does not use them.
Thanks for the PR @bkragnarok! I see you've re-implemented some of the ascii codes, like * and ?. These were (and I believe still are) forbidden characters for filenames on Windows which is why they have been replaced with a space in the original code.
Happy with the change to ansichar for the header, but can you explain why you've added +4 to the maxHeader.compressedSize value? The existing code worked at the time it was written and I'm not aware of any issues?
As you say, those ascii codes are forbidden for filenames, but these are read/write inside the file so I don't see the problem. Also, if it were up to me, I would entirely remove the ascii to shift jis part, I don't see the point of doing that because the max file cannot store non-ascii characters thus making imposible to restore characters like japanese names. If someone wants to get the game title in shift jis format it would be much better to get it directly from icon.sys.
As for the +4 thing, yes currently there are no issues for load/save because that part is irrelevant, but I noticed that in the max files created by AR there was a 4 byte discrepancy, idk why (maybe counts the original file size or something) so the point of this was to make it match the size that outputs the ones created by AR.
Also, when writing this, I noticed that I forgot to change line 864 because AR writes zeros instead of '?' for unknown characters.