porespy icon indicating copy to clipboard operation
porespy copied to clipboard

`pseudo_gravity` and `pseudo_electrostatic` packings should have `shape` or `im` as arguments

Open jgostick opened this issue 2 years ago • 1 comments

This is an api breaking change, so no rush.

jgostick avatar Feb 27 '22 03:02 jgostick

I am no longer in favor if this im_or_shape argument. Probably these functions should accept one or the other, like def func(im=None, shape=None, **kwargs). This means that all other arguments must have defaults, but I think this is ok. Even for the sphere radius, r=5 is not that bad of an assumption for a first pass.

jgostick avatar Feb 09 '23 01:02 jgostick