porespy icon indicating copy to clipboard operation
porespy copied to clipboard

Published 20 hours ago • verified publisher icon PMEAL

Improve ImageJ submodule to run in headless mode

Open ma-sadeghi opened this issue 3 years ago • 4 comments

See here for more details.

ma-sadeghi avatar Feb 27 '21 02:02 ma-sadeghi

We've also forced unit tests to only run for Windows. This should also be removed once this issue is dealt with.

ma-sadeghi avatar Apr 07 '21 19:04 ma-sadeghi

For future reference: https://javadoc.scijava.org/ImageJ/net/imagej/ops/image/watershed/Watershed.html

ma-sadeghi avatar Jul 22 '21 18:07 ma-sadeghi

Given that the imagej functions offer only minimal or zero performance improvements, we should probably not invest much more time into this module, and probably deprecate it in v3 down the road.

jgostick avatar Feb 15 '22 15:02 jgostick

It seems that the issue has been fixed upstream. Also, it seems that the speedup is real after all, and it's almost an order of magnitude (at least for some filters). So, I'd say let's reopen this issue.

ma-sadeghi avatar May 10 '22 20:05 ma-sadeghi

I don't think this is something porespy needs to manage for people. If they want to use imagej funcs from within python, they can figure it out.

jgostick avatar Aug 24 '23 13:08 jgostick