OpenPNM icon indicating copy to clipboard operation
OpenPNM copied to clipboard

Extracted network mistaken for a directed network

Open mkaguer opened this issue 2 years ago • 1 comments

An exception was raised in find_connected_nodes triggering an error that said, "This function is not implemented for directed networks". Talking to @ma-sadeghi I learned that a directed network has at least one bidirectional throat. When I check my network health, however, I have zero bidirectional throats. So I don't know why my network is triggering this warning. I am working on an extracted network. While I manipulated the 'pore.coords' I did not change 'throat.conns' at all. I can confirm as well that my throat.conns are conditioned well as i < j for any throat (i, j).

Click here to see where the exception was triggered.

mkaguer avatar Aug 15 '22 20:08 mkaguer

@mkaguer Could you please post a MWE (minimum working example) that reproduces the bug?

ma-sadeghi avatar Aug 16 '22 02:08 ma-sadeghi

This was not a bug in openpnm, but a bug in the network extractor. however, it reveals that we should have a better explanation of our 'convention' for what directed means. I am going to add this to the list of examples we should make.

jgostick avatar Aug 22 '22 14:08 jgostick