allofplos icon indicating copy to clipboard operation
allofplos copied to clipboard

Python 2 pip install should not work

Open asmacdo opened this issue 6 years ago • 3 comments

allofplos only works with Python 3, however, a Python 2 environment is able to install it.

To Reproduce:

$ mkvirtualenv 2plos
(2plos) $ python --version
Python 2.7.15
(2plos) $ pip install allofplos
pip install allofplos
Collecting allofplos
  Downloading https://files.pythonhosted.org/packages/88/a9/1c0e4f8bffc137f4aad5097682d5fa23504f97d50b1333e3658800c1b0db/allofplos-0.8.1-py2.py3-none-any.whl
Collecting certifi==2017.7.27.1 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/40/66/06130724e8205fc8c105db7edb92871c7fff7d31324d7f4405c762624a43/certifi-2017.7.27.1-py2.py3-none-any.whl
Collecting chardet>=3.0.4 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/bc/a9/01ffebfb562e4274b6487b4bb1ddec7ca55ec7510b22e4c51f14098443b8/chardet-3.0.4-py2.py3-none-any.whl
Collecting python-utils>=2.2.0 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/eb/a0/19119d8b7c05be49baf6c593f11c432d571b70d805f2fe94c0585e55e4c8/python_utils-2.3.0-py2.py3-none-any.whl
Collecting urllib3==1.22 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/63/cb/6965947c13a94236f6d4b8223e21beb4d576dc72e8130bd7880f600839b8/urllib3-1.22-py2.py3-none-any.whl
Collecting progressbar2>=3.34.3 (from allofplos)
  Downloading https://files.pythonhosted.org/packages/4f/6f/acb2dd76f2c77527584bd3a4c2509782bb35c481c610521fc3656de5a9e0/progressbar2-3.38.0-py2.py3-none-any.whl
Collecting idna>=2.6 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/4b/2a/0276479a4b3caeb8a8c1af2f8e4355746a97fab05a372e4a2c6a6b876165/idna-2.7-py2.py3-none-any.whl
Collecting tqdm==4.17.1 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/eb/90/123ff39f7e454566bcd7482244ca9893df92c28364351a3308b7091effa9/tqdm-4.17.1-py2.py3-none-any.whl
Collecting lxml>=4.0.0 (from allofplos)
  Downloading https://files.pythonhosted.org/packages/af/09/cdb478d8b0392edd4047c5d1f7e6a1fb5e0e7a2f8f14fcf05c6e9ae9edff/lxml-4.2.3-cp27-cp27mu-manylinux1_x86_64.whl (5.8MB)
    100% |████████████████████████████████| 5.8MB 3.1MB/s 
Collecting six>=1.11.0 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/67/4b/141a581104b1f6397bfa78ac9d43d8ad29a7ca43ea90a2d863fe3056e86a/six-1.11.0-py2.py3-none-any.whl
Collecting requests>=2.18.4 (from allofplos)
  Using cached https://files.pythonhosted.org/packages/65/47/7e02164a2a3db50ed6d8a6ab1d6d60b69c4c3fdf57a284257925dfc12bda/requests-2.19.1-py2.py3-none-any.whl
Installing collected packages: certifi, chardet, six, python-utils, urllib3, progressbar2, idna, tqdm, lxml, requests, allofplos
Successfully installed allofplos-0.8.1 certifi-2017.7.27.1 chardet-3.0.4 idna-2.7 lxml-4.2.3 progressbar2-3.38.0 python-utils-2.3.0 requests-2.19.1 six-1.11.0 tqdm-4.17.1 urllib3-1.22

asmacdo avatar Jul 14 '18 17:07 asmacdo

Yes, this is huge! Liked potential solution of making a dummy build 0.8.2 that worked for Python2 that basically said "do not install" so it supersedes 0.8.1, without needing to delete our older builds & thus preserving the history. Looking forward to hearing what the IRC pypi folks recommend!

eseiver avatar Jul 14 '18 19:07 eseiver

The "dummy package" is ok as a workaround, but the pypa folks recommended that we delete the older builds. If preserving the history is important, we can optionally rebuild and do a new post-release.

So, we would delete 0.8.1 and release 0.8.1.post1.

asmacdo avatar Jul 14 '18 20:07 asmacdo

@mpacer thoughts? I'm ok with just deleting the old builds.

eseiver avatar Jul 14 '18 21:07 eseiver