feature - icons seeds

Open Andersonfrfilho opened this issue 5 years ago • 3 comments

Add icons seeds

Sep 30 '20 02:09 Andersonfrfilho

Hey, @Andersonfrfilho?!

I don't think this PR will be accepted, because it's failing CI tests.

The CI tests indicates that icon.name should match the added svg filename. Hence: seeds.svg.

To pass this test, you need something like this:

{ icon: { name: 'seeds' }, ids: ['search-result'] },

Let me know, if you need help.

Oct 11 '20 19:10 entrywayaudibly

@entrywayaudibly

{ icon: { name: 'seeds' }, ids: ['search-result'] },

but why would I have to use another name like id, search-result instead of seeds ?

Oct 16 '20 18:10 Andersonfrfilho

My bad!

It's just your branch, which is outdated. Hence, it's missing search.svg.

Icon not found: search.svg

Further than that: it would be cool to minify seeds.svg, in order to reduce file size.

Oct 16 '20 21:10 entrywayaudibly