PKief
Some contributors not tagged in releases
I noticed that some contributors in certain releases were not tagged, unlike the other listed contributors.
In the latest release, for example, neither I nor Huuya were tagged. I had already seen this happen with me and Jan Schmidt in release v5.25.0, but I assumed it was an isolated case, since in the previous release both I and all the others had been tagged — even though the Contributors section was left out.
As a possible clue, a few months ago I reached out to @PKief to report that my e-mail address had appeared in a release instead of my username, which was fixed at that time. I’m not sure if this helps in any way, but it might be related to the bug I’m reporting here.
Let me know if there is anything I can do to help.
Thanks for reaching out @marlondecol. I've also noticed that your username is not tagged in the release notes. When you commit your changes, are you using the same public email address which is linked in your Github Account? I've analyzed the changelogen repo (which we're using for the changelog generation) and it seems that it doesn't get the username if there's a mismatch with your committer email address and your public account address.
Well, the addresses are the same, but the one on my profile is not set to public. Could that be the cause?
yes, that could be the case! Either you try to set it to public, or we can try to find a fix for changelogen. I honestly don't know exactly why they need to fetch the username based on the email address. I've seen some comments in their repo which say that they need the email to get a unique username. We need to figure that out.
Indeed, it doesn’t seem to make much sense, since usernames are unique by nature, but there must be some reason for this behavior. On the other hand, even without knowing the implementation details of that project, I believe there should be a way to work around this issue.
Although my commits contain my e-mail address, I would prefer to keep it private, at least on my profile, so I personally think it would be worthwhile to try to find a fix for them at some point.
I’ve been searching for a possible solution for this and came across it in a PR that was opened almost 2 years ago in unjs/changelogen#155. Let’s see if we can get it merged.
@marlondecol For the latest release it worked. I've applied a patch the last days which basically brings the changes of https://github.com/unjs/changelogen/pull/294 to our project as a patch commit: a0538ab8f9917cd326a63348566d868488bfa57e. Could you please double check if everything looks good now?
I double checked and confirmed that my tag is there. I really appreciate your effort and dedication. Thank you!