vscode-material-icon-theme icon indicating copy to clipboard operation
vscode-material-icon-theme copied to clipboard

BLoC folder icon

Open nulkode opened this issue 1 year ago • 3 comments

Description

Added BLoC folder icon.

Closes #2585. Closes #1461.

Contribution Guidelines

nulkode avatar Sep 10 '24 14:09 nulkode

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

github-actions[bot] avatar Sep 10 '24 14:09 github-actions[bot]

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

nulkode avatar Oct 05 '24 07:10 nulkode

@PKief sorry for mentioning, but can I get some feedback or can I get this merged?

The motive of this folder icon is a little different to all of the other folder icons of this extension. It has too many colors and this black border, which is not looking good and not consistent to the other folder icons.

Please take a look at the contribution guidelines to get more information on how to design good folder icons.

PKief avatar Oct 06 '24 05:10 PKief

@PKief done, I believe that now the motive fits better with the other folder icons.

nulkode avatar Dec 24 '24 16:12 nulkode

@nulkode Unfortunately we had an issue with our CI and some changes were gone. That's why this PR was closed by mistake. Would you mind pushing your changes from your local branch again?

PKief avatar Jan 06 '25 23:01 PKief

I've created a follow up PR: #2795

PKief avatar Jan 06 '25 23:01 PKief