Open-Sora-Plan icon indicating copy to clipboard operation
Open-Sora-Plan copied to clipboard

[feat]: add 2D RoPE

Open jpthu17 opened this issue 3 months ago • 2 comments

jpthu17 avatar Mar 07 '24 14:03 jpthu17

Hi! Please consider adding it to Latte as well, because there's a plan to make it the main codebase instead of vanilla DiT

And both variants may also benefit if it's added to the OpenDiT repo as well https://github.com/NUS-HPC-AI-Lab/OpenDiT/

kabachuha avatar Mar 07 '24 15:03 kabachuha

Another note is that if you're adding Rotary embeddings, you need to remove the sinusoidal ones, to not repeat them

kabachuha avatar Mar 07 '24 15:03 kabachuha