PH5 icon indicating copy to clipboard operation
PH5 copied to clipboard

Turkey hunting, remove unused code.

Open dsentinel opened this issue 6 years ago • 2 comments

There are unused modules, cli's, and functions. Some don't even run. Some create dependencies that may no longer be needed.

There are some functions written to handle specific experiments/datasets. These should be dropped, made for general use, or places somewhere appropriate.

The low hanging fruit is to remove the modules; files/cli tools/entry-points that are not being used, and dependencies unique to them.

The DG at PIC is going to compile a list of CL tools (entry points) that they don't use. When that reaches a consensus the list can be posted here and the axing can begin.

Ideally, this should happen before unit tests get expanded like #347 We don't want to write tests for code that's going to disappear.

dsentinel avatar Sep 13 '19 18:09 dsentinel

The turkey: https://github.com/PIC-IRIS/PH5/blob/9cf2ad34e0949d68d02d749b8ffb760b5816aebe/ph5/core/mplturkey.py#L74

dsentinel avatar Sep 13 '19 19:09 dsentinel

Issue is being closed due to shifting development efforts to GeoHDF.

ascire-pic avatar Oct 20 '20 17:10 ascire-pic