phpfastcache icon indicating copy to clipboard operation
phpfastcache copied to clipboard

Published 20 hours ago • verified publisher icon PHPSocialNetwork

Compatibility with php 8.4

Open srjlewis opened this issue 1 year ago • 3 comments

@Geolim4 hope this helps

Also could you do a release of PHPSocialNetwork/couchbasev4-extension 😊

Deprecate implicitly nullable parameter types https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

srjlewis avatar Oct 10 '24 10:10 srjlewis

Thanks, I take a look tonight !

Geolim4 avatar Oct 14 '24 07:10 Geolim4

I think I'm gonna throw travis Ci as it become more and more unstable over the years...

Geolim4 avatar Oct 14 '24 08:10 Geolim4

Yep I dont blame you, I do think git actions dose a better job these days.

srjlewis avatar Oct 14 '24 09:10 srjlewis

@Geolim4

Could I give you a little nudge as a reminder on this pull 😁

Also do you mind if I push a release out for PHPSocialNetwork/couchbasev4-extension or would you prefur to do it?

srjlewis avatar Oct 24 '24 08:10 srjlewis

Can you add a commit to remove travis.yml please ? As they don't support it, I have to get rid of them to keep only Github Actions.

I'll merge it tonight !

Geolim4 avatar Oct 24 '24 09:10 Geolim4

Yes I have removed it for you.

srjlewis avatar Oct 24 '24 09:10 srjlewis

@Geolim4 It also looks like Scrutinizer is have trouble, it cant even compile PHP 8.0 and throwing a error.

srjlewis avatar Oct 24 '24 09:10 srjlewis

@Geolim4 I know you are a busy man, just a reminder nudge. 😊

srjlewis avatar Nov 11 '24 15:11 srjlewis

Can you take a look at why the tests fails on GetAllItems on 8.4 ? I don't know if its related to this PR ?

Geolim4 avatar Nov 11 '24 21:11 Geolim4

Hi @Geolim4

TLDR: not related to this PR

The test that failed was on PHP 8.3.13

I was having a look yesterday when I see the tests fail. It looks like a redis, some thing has changed in the setup. The only thing that looks to of changed could be the redis php extention https://pecl.php.net/package/redis

When I first subbmitted the PR all tests passed on my fork Attempt 1 When I see the tests fail yesterday I reran the same tests on my fork and it failed Attempt 2

I have been able to get the tests to pass by the following commit on a test branch https://github.com/srjlewis/phpfastcache/commit/61d2acf3ddc7f8704c333b6c0a2db046b74022fa by removing redis from GetAllItems.test.php

I also have it passing with PHP 8.4 with the above fix https://github.com/srjlewis/phpfastcache/actions/runs/11795587335

I have also noticed that the tests are still running against redis 5, would it be a better idea to move redis to an extention and then also test against redis 6 and 7, just a idea so dont shot me 🤪

srjlewis avatar Nov 12 '24 10:11 srjlewis

Hello, I'm adding a small nudge to this one. Would it be possible to get this one over the line to make it PHP 8.4 compatible?

knyjoh avatar Mar 17 '25 15:03 knyjoh

Thank you @srjlewis, was merged in another PR that someone reasked me today. I'll be more active these next months !

Geolim4 avatar Apr 30 '25 05:04 Geolim4