PhpSpreadsheet icon indicating copy to clipboard operation
PhpSpreadsheet copied to clipboard

Feature xlsx drawing rich data

Open rapaelector opened this issue 5 months ago • 4 comments

This is:

  • [ ] a bugfix
  • [x] a new feature
  • [ ] refactoring
  • [x] additional unit tests

Checklist:

  • [ ] Changes are covered by unit tests
    • [ ] Changes are covered by existing unit tests
    • [x] New unit tests have been added
  • [x] Code style is respected
  • [ ] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • [ ] CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • [ ] Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate). If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

rapaelector avatar Sep 30 '25 21:09 rapaelector

Aside from fixing errors, this PR needs a much better description. Please edit it to provide one.

oleibman avatar Sep 30 '25 21:09 oleibman

Still working on it sorry for that

rapaelector avatar Sep 30 '25 22:09 rapaelector

I was also working on it on a branch based on the PR for read part (https://github.com/PHPOffice/PhpSpreadsheet/pull/4664). I still have to fix phpstan, check under real conditions and add tests: https://github.com/raziel057/PhpSpreadsheet/commit/4ccf9c044dafefbe19e9eedb29ebc22c6e2ff77b

raziel057 avatar Sep 30 '25 23:09 raziel057

You can close this PR in favor of this one https://github.com/PHPOffice/PhpSpreadsheet/pull/4677 as it's working. I propose you to have a look and test it on your side.

raziel057 avatar Oct 03 '25 23:10 raziel057