PhpSpreadsheet icon indicating copy to clipboard operation
PhpSpreadsheet copied to clipboard

Bug in resizeMatricesExtend

Open oleibman opened this issue 6 months ago • 2 comments

Fix #4451. The reporter's analysis is correct - the method has a bug. The solution is relatively easy. Nevertheless, proving that the fix works as desired is tricky. The submitter's Reflection test is good, but it would be better to find one within Excel. My additional tests are contrived, for reasons explained in the test member. So, I will leave this as a work in progress while I search for something better. If that search doesn't succeed, I will nevertheless merge this in about a month.

This is:

  • [x] a bugfix
  • [ ] a new feature
  • [ ] refactoring
  • [ ] additional unit tests

Checklist:

  • [ ] Changes are covered by unit tests
    • [x] Changes are covered by existing unit tests (SUMPRODUCT and Gnumeric and Ods ArrayFormulaTest)
    • [x] New unit tests have been added
  • [x] Code style is respected
  • [x] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • [ ] CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • [ ] Documentation is updated as necessary

oleibman avatar May 17 '25 03:05 oleibman

❤️

kikik-dev avatar May 17 '25 14:05 kikik-dev

Month is up. I have made no progress on a better test case, but need to move forward with the fix anyhow.

oleibman avatar Jun 18 '25 06:06 oleibman