PhpSpreadsheet icon indicating copy to clipboard operation
PhpSpreadsheet copied to clipboard

Fix division by zero warning

Open zakariaejaidi opened this issue 2 years ago • 1 comments

PHP Warning: Division by zero in /vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Calculation/Financial/CashFlow/Variable/Periodic.php on line 155

This is:

- [ x] a bugfix
- [ ] a new feature
- [ ] refactoring
- [ ] additional unit tests

Checklist:

  • [ ] Changes are covered by unit tests
    • [ ] Changes are covered by existing unit tests
    • [ ] New unit tests have been added
  • [x] Code style is respected
  • [ ] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • [ ] CHANGELOG.md contains a short summary of the change
  • [ ] Documentation is updated as necessary

zakariaejaidi avatar Jan 21 '23 01:01 zakariaejaidi

When we implement a bugfix, we always try to create a unit test to verify the original problem and confirm that the bugfix works as expected. Would you be able to create a unit test for this fix?

MarkBaker avatar Jan 21 '23 11:01 MarkBaker

No update in over a year. Closing.

oleibman avatar May 16 '24 04:05 oleibman