PhpSpreadsheet
PhpSpreadsheet copied to clipboard
PHPOffice
Workaround for Scrutinizer Initialization Problem
Fix #2732, which see for details. Solution suggested by @odan.
This is:
- [ ] a bugfix
- [ ] a new feature
- [x] Scrutinizer workaround
Checklist:
- [x] Changes are covered by unit tests
- [x] Code style is respected
- [ ] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
- [ ] CHANGELOG.md contains a short summary of the change
- [ ] Documentation is updated as necessary
Why this change is needed?
Failed twice now (with no real indication why), clearly too unstable to merge. Reverting to draft status, will continue to test periodically.
@oleibman I'm planning to do a release tomorrow or Monday; is there anything that you especially want to push through into 1.23.0?
@MarkBaker #2772 is probably ready. No strong feelings about whether it should or should not be in new release.
Worked this time. Still took a very long (almost 10 minutes) to set up 8.1 environment. There are approximately as many new issues introduced (14) as existing issues fixed (15) since the last successful Scrutinizer run. Results haven't convinced me to merge this change, but I will continue to test.
Still very slow. Complete in 18 minutes 44 seconds on 2022-08-14. 99 new issues, 75 issues fixed, since last run. It'll probably be a mess if performance ever gets to the point when we want to enable.
Good results - down to 12 new issues (11 minor 1 unknown), with 57 issues fixed. Overall time still very long (over 20 minutes excluding almost 10 minutes in queue).
Scrutinizer appears to be working this morning (2022-09-12) without this override. I will monitor for a few days, and close this ticket if that continues to be the case.