PHPWord icon indicating copy to clipboard operation
PHPWord copied to clipboard

Published 20 hours ago • verified publisher icon PHPOffice

Allow to customize macro delimiters in TemplateProcessor

Open ismail1432 opened this issue 2 years ago • 0 comments

Description

Hello 👋

Congratulations on this huge project 🔥

I'm glad to open a pull request with new additions where the goal is to allow developers to customize macros delimiters with 3 methods:

  • setMacroOpeningChars
  • setMacroClosingChars
  • setMacroChars

You can see #2251 for more details.

💡 I ran composer run-script check --timeout=0 and got an output that is not related to the PR: CamelCasePropertyName The property $TOCStyle is not named in camelCase.

✅ I duplicated all tests related to the TemplateProcessor with the customization of macros and it works like a charm.

I let you check the PR let me know if something is wrong or if you need more information.

Checklist:

  • [x] I have run composer run-script check --timeout=0 and no errors were reported
  • [x] The new code is covered by unit tests (check build/coverage for coverage report)
  • [x] I have updated the documentation to describe the changes
  • [x] Add more tests

ismail1432 avatar Jul 15 '22 00:07 ismail1432