GoogleAuthenticator icon indicating copy to clipboard operation
GoogleAuthenticator copied to clipboard

rawurlencode the name

Open mschering opened this issue 6 years ago • 1 comments

The name of the account must be encoded with rawurlencode(). Otherwise it will fail to add on iOS devices if the name contains a space for example.

mschering avatar Sep 04 '18 15:09 mschering

This PR is no good - the $name parameter is being double-escaped.

A better solution would be to update all of the urlencode() calls to use rawurlencode(), instead.

MarkMaldaba avatar Mar 12 '21 13:03 MarkMaldaba