GoogleAuthenticator icon indicating copy to clipboard operation
GoogleAuthenticator copied to clipboard

Introducing namespace

Open chaos0815 opened this issue 7 years ago • 10 comments

As the title says the code is now using a namepsace. I've adjusted the test accordingly. please excuse the format changes. Bad habit of mine.

chaos0815 avatar May 17 '17 07:05 chaos0815

Sorry for the erratic commits. but I'm not used to working with travis.

chaos0815 avatar Jul 13 '17 06:07 chaos0815

Well, is there something opposing a merge? Asking for a friend.

chaos0815 avatar May 08 '18 14:05 chaos0815

Why a space between the dots? That makes it very confusing

Dennis1993 avatar May 08 '18 15:05 Dennis1993

@Dennis1993 whitespace between operands confuses you?

chaos0815 avatar May 09 '18 06:05 chaos0815

@chaos0815 I think this project is abandoned.

Ryan6578 avatar May 18 '18 16:05 Ryan6578

@PHPGangsta Michael, some feedback would be appreciated on why you would not accept this pull request. I believe introducing namespaces is the right way to go and I don't see any reasons not to.

chaos0815 avatar Jun 21 '18 15:06 chaos0815

@chaos0815 Once again, I'm pretty sure the project is abandoned. He's not going to get back to you because he is no longer interested in maintaining the project.

Ryan6578 avatar Jun 21 '18 16:06 Ryan6578

@Ryan6578 and you would know because?

chaos0815 avatar Jun 22 '18 05:06 chaos0815

@chaos0815 Look at the repository. The owner's last commit was nearly 2 years ago, the last time he merged a PR was nearly 2 years ago. There's been no activity from him on this repository since then. That's how I know.

Ryan6578 avatar Jun 22 '18 15:06 Ryan6578

Also, one of the nice things about this implementation, as opposed to some of the alternative libraries that are out there, is that it works on pretty much all PHP versions, including older PHP 5. Therefore, I don't think it's a great idea to introduce this kind of change, which removes that support for no actual benefit.

MarkMaldaba avatar Mar 12 '21 12:03 MarkMaldaba