PHP_CodeSniffer

PHP_CodeSniffer copied to clipboard

QA: "normalize" the code style rules used by this code base a little

5

The coding standard of this code base was historically/organically grown and is likely influenced by some internal rules which were being used in Squiz projects at one time or another....

jrfnl

Avoid incompatibility between `Generic` and `PSR2` standards for function call indentation

6

## Description This is a re-creation of https://github.com/squizlabs/PHP_CodeSniffer/pull/3631 > `Generic.WhiteSpace.ScopeIndent` and `PSR2.Methods.FunctionCallSignature` both try to fix indentation differently. This results in files not being able to be fixed automatically with...

fredden

[Documentation] Squiz: Function Spacing

3

# Description This PR adds documentation for the `Squiz.WhiteSpace.FunctionSpacing` Sniff. ## Suggested changelog entry Add documentation for the Squiz Function Spacing Sniff ## Related issues/external references Part of https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/148 ##...

jaymcp

Generic/DisallowYogaConditions: false negatives when handling arrays

1

## Describe the bug The Generic.ControlStructures.DisallowYodaConditions sniff has a method called `isArrayStatic()` that determines what the sniff considers to be static arrays. When static arrays are found on the side...

rodrigoprimo

False positive Generic.ControlStructures.DisallowYodaConditions

4

Repost from https://github.com/squizlabs/PHP_CodeSniffer/issues/2962: > The `Generic.ControlStructures.DisallowYodaConditions` reports a `Usage of Yoda conditions is not allowed; switch the expression order` error for the below code, which IMO is incorrect (the error,...

jrfnl

## Description Recreation of upstream PR https://github.com/squizlabs/PHP_CodeSniffer/pull/1542: > I've explicitly not added metrics for: > * lowercase keyword as those are already recorded by the `Generic.PHP.LowerCaseKeyword` sniff > * `break`/`return`...

jrfnl

Variable sniffs: minor performance tweak

2

## Description The `AbstractVariableSniff` by default listens to all `T_VARIABLE`, `T_DOUBLE_QUOTED_STRING` and `T_HEREDOC` tokens. The majority of the sniffs extending the `AbstractVariableSniff`, however, only handle `T_VARIABLE` tokens and in particular,...

jrfnl

Generic/DocComment: add XML documentation

4

## Description This PR adds the XML documentation for the Generic.Commenting.DocComment sniff. This sniff contains several errors, so I opted to add a `` block at the top summarizing all...

rodrigoprimo

Analysis: determine whether to revive of not

3

The original PHP_CodeSniffer project contained a code consistency analysis website: https://squizlabs.github.io/PHP_CodeSniffer/analysis/ That website hadn't been updated since 2018. For now, I've removed the site from the `gh-pages` branch of this...

jrfnl

FunctionCallSignature works incorrectly

2

## Describe the bug Seems PEAR.Functions.FunctionCallSignature.Indent sniff and fix works incorrectly with some nested structures. The problem appears when there is indentation issue together with another issue, like PEAR.WhiteSpace.ScopeIndent.Incorrect. After...

semirke