jwt-auth
jwt-auth copied to clipboard
PHP-Open-Source-Saver
ci(GitHub): update coverage reports
Codecov Report
Merging #92 (cd49063) into develop (8943820) will increase coverage by
0.35%. The diff coverage isn/a.
@@ Coverage Diff @@
## develop #92 +/- ##
=============================================
+ Coverage 93.43% 93.79% +0.35%
- Complexity 401 406 +5
=============================================
Files 41 41
Lines 883 934 +51
=============================================
+ Hits 825 876 +51
Misses 58 58
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/Token.php | 100.00% <0.00%> (ø) |
|
| src/JWTAuth.php | 100.00% <0.00%> (ø) |
|
| src/Blacklist.php | 100.00% <0.00%> (ø) |
|
| src/Claims/Claim.php | 100.00% <0.00%> (ø) |
|
| src/Claims/Custom.php | 100.00% <0.00%> (ø) |
|
| src/Claims/NotBefore.php | 100.00% <0.00%> (ø) |
|
| src/Claims/Collection.php | 100.00% <0.00%> (ø) |
|
| src/Claims/Expiration.php | 100.00% <0.00%> (ø) |
|
| src/Http/Parser/Parser.php | 100.00% <0.00%> (ø) |
|
| src/Http/Parser/Cookies.php | 100.00% <0.00%> (ø) |
|
| ... and 17 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8943820...cd49063. Read the comment docs.
@mfn as we discussed in #78 I've enabled coverage report. It will only comment if coverage was actually changed. I also updated to latest action version, since prev one was deprecated, and enabled coverage collection to each build, instead of selected one, Codecov can handle it and mergese theses reports properly
@leon0399 LGTM!
Is the codecov comment so verbose because it was "just enabled" https://github.com/PHP-Open-Source-Saver/jwt-auth/pull/92#issuecomment-1001655914 ?
@leon0399 LGTM!
Is the codecov comment so verbose because it was "just enabled" #92 (comment) ?
No, we actually can configure which parts of report we need https://docs.codecov.com/docs/pull-request-comments
Okay :)
Is the "graphic" useful?
Is showing files at 100% really useful?
I suggest to trim it down to what is truly additional + beneficial + actionable information to the author of a PR
Is the "graphic" useful?
Is showing files at 100% really useful?
I suggest to trim it down to what is truly additional + beneficial + actionable information to the author of a PR
I also thought of keeping only diff part, but thought to see which part we actually look into when reviewing and change after
Not super sold on it but looking forward how it plays out, thank you!
Those conflicts you'll solve it? I can take a look once I got some time if you want to.
Not super sold on it but looking forward how it plays out, thank you!
Those conflicts you'll solve it? I can take a look once I got some time if you want to.
I'll fix it later today
How about this MR? We're still having conflicts, @leon0399 can you solve it today since you're the one who knows what's going on behind it.
@mfn do you understand those CI's? Because if we don't merge it'll soonly appear more conflicts.
If no one can solve I'll take some time next to try to fix it.
@mfn since @leon0399 is been away for a while, what do you think to we solve those conflicts, or do you think it's better to wait for @leon0399 back?
@leon0399 how are you? It's been a long time since you didn't give feedback.
Anyway, If I got some time on the weekend I'll take a look at this, I've passed a hard time here at the end of the year.
This MR will be closed since the author didn't give feedback and no one continued his started job. We can re-open it in the future to add this new feature.