Silex-Bridge icon indicating copy to clipboard operation
Silex-Bridge copied to clipboard

Published 20 hours ago • verified publisher icon PHP-DI

Support Silex 2

Open naxhh opened this issue 7 years ago • 15 comments

So, the adapter seems very nice feature to have and avoid coupling to controllers but it does not work with silex 2 (composer.json specify silex 1.3)

Is any plan to make it work with silex 2?

naxhh avatar Aug 05 '17 10:08 naxhh

Hi, that's a good idea. I don't have the time to look into that at the moment but feel free to give it a shot?

mnapoli avatar Aug 05 '17 20:08 mnapoli

There has already been done some work in https://github.com/PHP-DI/Silex-Bridge/tree/silex-2. However, I'm not sure what's missing (if at all) and I'm currently pretty busy with my day job (plus I haven't used Silex 2 in any project for a while).

jdreesen avatar Aug 06 '17 11:08 jdreesen

Oh right sorry! There's even a beta release, @naxhh could you try it: https://github.com/PHP-DI/Silex-Bridge/releases/tag/2.0.0-beta1

mnapoli avatar Aug 06 '17 14:08 mnapoli

Sure. I'll try to test it this weekend and report back :)

EDIT: Hadn't have time that weekend let's see how this one goes...

naxhh avatar Aug 08 '17 07:08 naxhh

Any progress with moving to silex 2?

kordos avatar Sep 26 '17 12:09 kordos

Hi! I was on holidays and in that time I abandoned that project so I didn't had the requirement to test this anymore.

I'm ok closing this issue or just keeping it open in case someone wants to test this.

naxhh avatar Sep 26 '17 15:09 naxhh

👍 no worries, let's keep this issue open though.

mnapoli avatar Sep 26 '17 17:09 mnapoli

Hi, I added pull request with silex 2 support. It works perfectly with my service. Please review my pull request.

kordos avatar Nov 16 '17 09:11 kordos

@kordos have you seen the changes in this branch: https://github.com/PHP-DI/Silex-Bridge/commits/silex-2 ? Maybe there are some things to keep from there.

mnapoli avatar Nov 18 '17 11:11 mnapoli

Yes. My pull request is from this branch(silex-2)

kordos avatar Nov 20 '17 09:11 kordos

@mnapoli or @jdreesen can you merge my pull request with silex 2 support?

kordos avatar Dec 07 '17 08:12 kordos

Done. @jdreesen is the current status of the silex-2 branch good for you? We could tag a release (even a beta if we are not 100% confident) to get things moving?

mnapoli avatar Dec 07 '17 18:12 mnapoli

It works perfectly in one of my projects. I didn't see any problems yet. In near future I will migrate other microservices to silex 2 and test it in production. I'm wondering what tag it should get. Definitely I'm not using all features of silex 2 so I'm not 100% sure that everything works(but it works for my usage). At least we can tag it beta2 and after some time if no errors come up we can tag it as 2.0.0. @mnapoli what do you think?

kordos avatar Dec 08 '17 09:12 kordos

@jdreesen or @mnapoli can you add tag to silex-2 branch? I don't have permissions for it

kordos avatar Dec 11 '17 15:12 kordos

@kordos The silex branch is behind master: https://github.com/PHP-DI/Silex-Bridge/compare/silex-2...master (there are commits in master that were not integrated in this branch) => could you reintegrate those commits into the branch ? (via a pull request for example, but github tells me there are conflicts to solve)

I'm also wondering whether it makes sense to continue tu support Silex since it's now deprecated 🤔

mnapoli avatar Dec 28 '17 14:12 mnapoli