PHARE
PHARE copied to clipboard
PGI C++ compiling/test passing
gtest define macro causes issues
https://github.com/google/googletest/issues/3390
sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h
edit: resolved by cmake refactor, declare CXX_STANDARD after deps
highfive cmake config issue with PGI https://github.com/BlueBrain/HighFive/issues/446
build passing on TC https://hephaistos.lpp.polytechnique.fr/teamcity/buildConfiguration/Phare_Phare_GhPrPgccSamraisub
gtest define macro causes issues
sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h
edit: resolved my cmake refactor, declare CXX_STANDARD after deps
why isn't the root cmakelists.txt modified then ?
gtest define macro causes issues google/googletest#3390
sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h
edit: resolved my cmake refactor, declare CXX_STANDARD after deps
why isn't the root cmakelists.txt modified then ?
because I haven't merged the updates from https://github.com/PhilipDeegan/PHARE/blob/openacc_pusher/CMakeLists.txt#L17
close @nicolasaunai ?
why closing if that helped being compliant with PGI at reasonable cost? On the other hand, if we have no PGI build on the CI, it might be difficult to assess whether this PR is enough and stays enough in the future
rebase/retry with pgcc on tc
possibly move to fork, thoughts @nicolasaunai ?