PHARE icon indicating copy to clipboard operation
PHARE copied to clipboard

PGI C++ compiling/test passing

Open PhilipDeegan opened this issue 3 years ago • 9 comments

PhilipDeegan avatar Apr 29 '21 11:04 PhilipDeegan

gtest define macro causes issues

https://github.com/google/googletest/issues/3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved by cmake refactor, declare CXX_STANDARD after deps

PhilipDeegan avatar Apr 29 '21 12:04 PhilipDeegan

highfive cmake config issue with PGI https://github.com/BlueBrain/HighFive/issues/446

PhilipDeegan avatar Apr 29 '21 13:04 PhilipDeegan

build passing on TC https://hephaistos.lpp.polytechnique.fr/teamcity/buildConfiguration/Phare_Phare_GhPrPgccSamraisub

PhilipDeegan avatar May 03 '21 16:05 PhilipDeegan

gtest define macro causes issues

google/googletest#3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved my cmake refactor, declare CXX_STANDARD after deps

why isn't the root cmakelists.txt modified then ?

nicolasaunai avatar May 09 '21 10:05 nicolasaunai

gtest define macro causes issues google/googletest#3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved my cmake refactor, declare CXX_STANDARD after deps

why isn't the root cmakelists.txt modified then ?

because I haven't merged the updates from https://github.com/PhilipDeegan/PHARE/blob/openacc_pusher/CMakeLists.txt#L17

PhilipDeegan avatar May 09 '21 10:05 PhilipDeegan

close @nicolasaunai ?

PhilipDeegan avatar Mar 14 '22 10:03 PhilipDeegan

why closing if that helped being compliant with PGI at reasonable cost? On the other hand, if we have no PGI build on the CI, it might be difficult to assess whether this PR is enough and stays enough in the future

nicolasaunai avatar Mar 14 '22 20:03 nicolasaunai

rebase/retry with pgcc on tc

PhilipDeegan avatar Oct 13 '23 20:10 PhilipDeegan

possibly move to fork, thoughts @nicolasaunai ?

PhilipDeegan avatar Jan 04 '24 12:01 PhilipDeegan