OpenTerrainGenerator icon indicating copy to clipboard operation
OpenTerrainGenerator copied to clipboard

Bug: 1.16 - Unable to assign border biomes to new oceans

Open BiomeBundle opened this issue 4 years ago • 5 comments

Adding a border to the new ocean biomes doesn't work.

BiomeBundle avatar May 08 '21 17:05 BiomeBundle

This could be from BiomeBorderLayer#sample() calling BiomeLayers#getBiomeFromLayer(), which is checking for land bit. If it doesn't have land bit set, it will return 0 as the default ocean biome ID. That would mean BiomeBorderLayer can't see the different biomes in the ocean, just that they are oceans.

authvin avatar May 09 '21 13:05 authvin

Correct, also a problem is that the climate-specific ocean biomes are only determined after all gen depths are processed, so only default ocean exists while processing borders/isles.

PG85 avatar Jul 03 '21 00:07 PG85

Since 0.0.15, multiple border biomes of the same size can now be assigned to biomes. Since all ocean types are recognised as default ocean for the purposes of border biomes, you can at least make borders for the land<>ocean boundaries, though not for the ocean<>ocean boundaries.

PG85 avatar Jul 03 '21 12:07 PG85

Thanks for reporting this, will use #599 for this.

PG85 avatar Jul 09 '21 16:07 PG85

Implementing this requires rewriting the ocean system, targeting 1.0.0

SXRWahrheit avatar Jul 31 '21 15:07 SXRWahrheit