[1.12] Performance improvements, bug fixes and clean up

[Meldexun]

This PR is a collection of a lot of performance improvements, bug fixes and a bit of code clean up. Due to the huge amount of changes I recommend checking every commit individually. This should be doable because every commit only changes a single thing and the individual changes are (currently) not split among multiple commits.

Currently all changes are untested. I will try to do some testing in the next days and report back.

Here is a list of the reasoning behind each commit:

• Improve LocalWorld#isStructureInRadius implementations Performance: Iterate whole area directly instead of going in circles (usually done to find the nearest structure but that isn't needed here) Bug Fix: MapGenStructure#canSpawnStructureAtCoords may crash due to MapGenBase#world being null Clean up

• Improve EntityNames#toInternalName Performance: Very slow, iterates map + a lot of regex. Not exactly the same functionality as before. Previously it removed all occurances of "minecraft:", "entity" and "_". This means something like z_ominecraft:mbentityi_e__ would be a valid alias for zombie. Now only the "minecraft:" prefix is removed and the aliases specified by EntityNames are supported.

• Fix captureBlockSnapshots corruption when setBlockState errors Bug Fix: When Chunk#setBlockState throws an exception the captureBlockStates field might get corrupted which creates a massive memory leak

• Clean up BlockPos2D Clean up

• Fix missing BlockPos2D#hashCode implementation Bug Fix: This class is used as a HashMap key in OTGChunkGenerator but is missing a hashCode implementation

• Clean up BlockPos3D Clean up

• Fix BlockPos3D#equals Bug Fix: y coordinate is not compared

• Fix missing BlockPos3D#hashCode implementation Bug Fix: Didn't find any hash map usage but doesn't hurt to implement this as well

• Replace FifoMap with LRUCache Performance: Use access order instead of write order to determine which entry to remove (LRU instead of FIFO). Also, initialize map with sufficient size so that no resizing is ever needed,

• Improve DimensionConfigBase constructor Performance: Avoid creating ArrayList just to call toArray in the end

• Improve DefaultMaterial lookups Performance: Use HashMap instead of TreeMap for lookupName Clean up

• Improve PlantType lookup Performance: Use HashMap instead of TreeMap for LOOKUP_MAP

• Improve ChunkGenerator#getChunk Performance: Caching like this only hurts performance. Calling getLoadedChunk is unnecessary if just calling getChunk when the result is null.

• Clean up BiomeGroup Clean up

• Fix unnecessary ArrayList creation Performance: Iterate list directly instead of creating ArrayList from sub list

• Improve BiomeGroup depth map cache Performance: BiomeGroupManager#isBiomeDepthMapEmpty only checks if any depth map is non-empty but this can be done without creating a depth map.

• Remove unnecessary initGroupSeed call Clean up: LayerLandRandom doesn't call nextGroupInt which makes this useless

• Rename getRandomOf4 to mostCommonOrRandom Clean up: Confusing name

• Improve mostCommonOrRandom Performance: Less comparisons

• Add InvalidConfigException constructor with cause argumnet Feature: Adds option to create InvalidConfigException with a cause. Stacktrace won't be truncated when throwing a InvalidConfigException using the new constructor this way.

• Clean up StringHelper Performance: Avoid Collection#toArray in join. Use InvalidConfigException constructor with cause. Clean up

• Improve StringHelper.readCommaSeperatedString Performance: Use ArrayList instead of LinkedList. Return List instead of calling List#toArray at the end. Clean up

• Clean up Resource.hashCode Clean up

• Improve FileSettingsReaderOTGPlus.readSettings Performance: Only use up to 3 calls to indexOf or lastIndexOf per line. Clean up

• Improve NBT reading Performance: Use BufferedInputStream

• Fix silver shulker box id Bug Fix: Wrong id (228 is cyan shulker box)

• Add glazed terracotta Bug Fix: Add missing glazed terracotta entries

• Remove "UNKNOWN_BLOCK" Bug Fix: IDs not used by vanilla will used by mods

• Add fastutil dependency Feature: Make FastUtil 7.1.0 available in common package as it is used by Minecraft already

• Improve layer random number generator Implement custom RNG (similar to java.util.SplittableRandom) to generate good random numbers. LayerRNG serves as an abstraction layer to support legacy RNG implementation for old worlds. Store WorldSaveData in ServerConfigProvider to be able to determine the OTG which was used to create a world. ~~NOTE: Currently the new RNG is unused because it expects the world creation version to be >=9 but I didn't change the world creation version yet (see here)~~Fixed

• Create WeightedList to replace TreeMap iteration Performance: Implement WeightedList to avoid TreeMap iteration. WeightedList#getRandom returns a random element based on the weight by traversing a AVL tree.

• Format LocalMaterialData Clean up

• Format ReplacedBlocksMatrix Clean up

• Reimplement LocalMaterialData Reimplementation of LocalMaterialData and its subclasses for various performance improvements and bug fixes. The most important changes are: Use enum + Reference2IntMap to greatly speed up MaterialSet#contains Make LocalMaterialData immutable Replace LocalMaterialData#canSnowFallOn with LocalWorld#canPlaceSnowAt to allow correct checking if snow is placeable Avoid all DefaultMaterial methods because most are just approximations and don't work for modded blocks anyway