PF4Public

Results 431 comments of PF4Public
trafficstars

@ureimers Please check if you could reproduce this issue with https://ungoogled-software.github.io/ungoogled-chromium-binaries/releases/windows/64bit/117.0.5938.150-1 and with empty profile

What is the purpose of mDNS? Could it be abused somehow in the future if we enable it?

> It's how Avahi or Bonjour work if you're familiar with those Those are the things that are banned/blocked/removed from my systems that's why I'm concerned ;)

Should we merge before or after 107? 🤔

> I wonder if the patch could be simplified to that and it's flag since it shouldn't be able to make connections in the first place. Won't it crash somewhere...

Then I suppose this could be a better solution to make everyone happy :)

@Ahrotahn Please check whether this feature works as intended after my intervention and whether it is ready for merge.

@Ahrotahn I had a hard time figuring the logic behind this inverted flag and I would be in favour of making it "less inverted" for the sake of avoiding the...

> but inverting the flag made it such that MDNS is disabled by default It is [disabled right now via flags.gn](https://github.com/ungoogled-software/ungoogled-chromium/blob/891b80bbfcdb15e8292143efd1715fa3f30662c4/flags.gn#L6)

> @PF4Public I was referring to this line: [c6fa0d4#diff-0d417477f79d089dbf61e8105859741606baaf2d56f6382c31397795eabb8910L85](https://github.com/ungoogled-software/ungoogled-chromium/commit/c6fa0d4936a4b1f17d0eee52b91b7deb0d41db2f#diff-0d417477f79d089dbf61e8105859741606baaf2d56f6382c31397795eabb8910L85) This line changes nothing since we disable mdns via flags.gn anyway.