Peter Strömberg

Results 545 comments of Peter Strömberg

> I haven't heard back, and you're usually quick with PR feedback, so I’m wondering if something’s missing. Hi! I'm sorry. Didn't see this PR. Now will check. By the...

Wow. Thanks! And extra thanks for adding that test! 🙏 ❤️ I didn't even know these kind of facilities existed. 🤯 You are most welcome to add documentation about it...

I don't understand why the CircleCI job is not run for this PR. That I must fix ASAP!

> I couldn't fit the `store_artifacts` command into the existing `store` definition below because it requires both `path` and `destination` parameters I think it's perfect as you did it.

Great that you figured out about the PR builds missing. I can understand that they want to save compute, but seems this could be solved by showing the runs from...

Hi! Thanks for reporting. This is better brought up with [clj-kondo](https://github.com/clj-kondo/clj-kondo): ```sh $ clj-kondo --lint -

Thanks for helping with Calva, @pbwolf! ❤️ 🙏 It looks good to me, but seems Prettier is unhappy with something: https://app.circleci.com/pipelines/github/BetterThanTomorrow/calva/8331/workflows/5d10663b-8400-415b-a958-38eb11082c72/jobs/45673?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

Hi! What is the purpose behind these refactorings?

So sweet! Thanks for working on this! 🙏