Pierre-Eric Marchandet

Results 116 comments of Pierre-Eric Marchandet

Some kind of off canvas rendering, interesting idea.

Indeed, concerning the inlined styles, this should be treated here: https://github.com/facebook/react/blob/master/src/renderers/dom/shared/CSSPropertyOperations.js#L172

I'm doing it right now. I'll reference our issue in FB's repo.

I've also referenced this issue on html-minifier as it should not alter inline styles when `minifyCss` is set to `false`.

Thanks @toinevk Some remarks before I can merge your contribution: * This enhancement is targeted for 3.0.0, it should be on the `development` branch instead of the `master` one. We...

We normally send a HTTP 200 OK when browser don't get the HTTP 304. If you happen to reproduce this, some help on this issue would be appreciate.

@j-jackson As stated in the description, you can already do it with `asymetricSsr`. This enhancement concerns the cache handling to avoid filling it with already rendered HTML payload.

This does the trick for me: ``` const myScriptUrl = 'https:/blablabla/' const MyComp = () => { const [scriptLoaded, setScriptLoaded] = useState(typeof window !== 'undefined' && typeof myScript !== 'undefined')...

@nlhuykhang That would be a pretty nice addition to Meteor. Do you intend to push a PR on their repo?

Unfortunately, no chance on my side. Spacebar requires far too much time to write :sweat: and my time is too scarce for the time being. I can leave this issue...