klh10 icon indicating copy to clipboard operation
klh10 copied to clipboard

read20 should print author information

Open ams opened this issue 3 years ago • 4 comments

TOPS-20 tapes store author information, read20 should print it.

For dump.h add:

#define WdoffAuthor      WdoffFDB+030   /* Author offset */

Then in doFileHeader:

    getstring(block, authorname, WdoffAuthor, sizeof(authorname), STRING);

and print it when in verbose mode:

printf("%5d%9d %2d %o %s %s %s", offline ? apgcount : pgcount,
                   numbytes, bytesize, tprot, timeptr, topsname, authorname);

ams avatar Nov 22 '22 15:11 ams

Sounds like a good idea! When I try to compile read20, I notice lots of compiler warnings. I'll clean it up first, and then get to your change.

Rhialto avatar Nov 22 '22 17:11 Rhialto

Hm, is there any reason to clean up? Wouldn't it be better to sync this version of read20 with the one in https://github.com/brouhaha/tapeutils ?

ams avatar Nov 22 '22 18:11 ams

I wasn't aware of that version It seems the version have diverged. Maybe it is smarter to ask brouhaha to incorporate any improvements that KLH made to this version.

Rhialto avatar Nov 22 '22 20:11 Rhialto

@brouhaha has mostly left the maintenance of https://github.com/brouhaha/tapeutils/ to me. Yes, I agree that merging all diverging versions to the brouhaha upstream would be good.

larsbrinkhoff avatar Nov 22 '22 21:11 larsbrinkhoff